C# Fixes wasi http header bug and adds a test for it#1215
Merged
yowl merged 14 commits intoApr 10, 2026
Conversation
jsturtevant
reviewed
Mar 17, 2025
jsturtevant
left a comment
jsturtevant
left a comment
Collaborator
There was a problem hiding this comment.
Is the fix here around the alignment? How was the issue presenting?
jsturtevant
reviewed
Mar 19, 2025
|
I ran into this issue as well. Are there any plans to land this fix or similar? Thanks 🙏 |
added 6 commits
March 27, 2026 17:44
# Conflicts: # crates/csharp/src/function.rs # crates/csharp/src/interface.rs # crates/csharp/src/world_generator.rs # tests/runtime/lists.rs # tests/runtime/lists/test.wit # tests/runtime/lists/wasm.cs
yowl
reviewed
Apr 3, 2026
yowl
left a comment
yowl
left a comment
Collaborator
There was a problem hiding this comment.
Had a brief look through and looks like a good improvement! Thanks!
Member
Author
Do you have the time to leave a review so I can merge it in? |
Collaborator
|
As I wasn't one of the original reviewers I was going to leave it for them, but I will review it with previous comments in mind, |
yowl
approved these changes
Apr 9, 2026
Collaborator
Just the small question on the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where headers returned from a C# component wouldn't be properly set. Adds a test for it and some cleanup.